Subject: | |
From: | |
Reply To: | |
Date: | Thu, 18 Sep 2008 14:21:30 +0100 |
Content-Type: | text/plain |
Parts/Attachments: |
|
|
Heiko Oberdiek wrote:
> On Thu, Sep 18, 2008 at 01:31:20PM +0100, Joseph Wright wrote:
[Handy comments ommitted]
>
> But above you have defined \char_make_other_char.
> In general I think, where Knuth has written "xy character"
> the word "character" could be omitted, because it is already
> present as first compound of the macro. Also it would make
> the macro name a little shorter. In part you have done it already:
>
> \char_make_escape
> \char_make_ignore
> \char_make_comment
> \char_make_invalid
>
> but
>
> ==> \char_make_other
> ==> \char_make_active
I was following what the team have done with, for example,
\token_if_other_char:NTF. I would personally agree with you, and have:
\char_make_other => \token_if_other:NTF
and so on, as the "_char" part is redundant in both, in my opinion.
--
Joseph Wright
|
|
|